[OpenMP] Document how to specify flags to device libraries #159053
Conversation
Since commit be6f110 we lost a few workarounds that prevented CPU-specific flags to leak from CXXFLAGS to a binary targetting GPUs causing errors and/or warnings. Re-add those workarounds and expand them with -mtune, -mbranch-protection and -fcf-protection.
llvmbot
added
openmp:libomp
jhuber6
left a comment
jhuber6
left a comment
There was a problem hiding this comment.
These are inherited from the global version, the correct solution (I think) is to do -DRUNTIMES_amdgcn-amd-amdhsa_CMAKE_CXX_FLAGS="" or something. If that works it might be reasonable behavior to put in the cache file.
I wonder if in the general case we should force users to be more specific on which flags are intended for the runtimes or not, but that might be a little user hostile. @petrhosek WDYT?
Add an explanation on how to use RUNTIMES_<triple>_CMAKE_CXX_FLAGS in order to specify different compiler flags for OpenMP device libraries.
|
@jhuber6 Thank you! That worked. |
tuliom
changed the title
jhuber6
left a comment
jhuber6
left a comment
There was a problem hiding this comment.
Yep, looks good. I need to get around to writing some more comprehensive documentation on the runtimes builds now that I'm trying to push everything further in that direction.
3 participants
Add an explanation on how to use RUNTIMES__CMAKE_CXX_FLAGS in
order to specify different compiler flags for OpenMP device libraries.